-
Notifications
You must be signed in to change notification settings - Fork 198
feat!: remove Elastic Trace processor from EDOT Collector #10378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove Elastic Trace processor from EDOT Collector #10378
Conversation
|
This pull request does not have a backport label. Could you fix it @andrzej-stencel? 🙏
|
🔍 Preview links for changed docs |
It is replaced with the Elastic APM processor.
e07e280 to
c1e9b4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Please revert the changes in components.md and custom-collector.md, since those docs are meant to show the latest stable release (9.1.5) and will update automatically upon 9.2 release.
I would also recommend to edit all the other sample configurations and backport (forwardport?) the changes to the cut 9.2 branch.
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
In anticipation of elastic#10378
Right, fixed in 56127ab. |
💚 Build Succeeded
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gregkalapos mind taking a look too?
* feat!: remove Elastic Trace processor from EDOT Collector It is replaced with the Elastic APM processor. * fix: add Elastic APM processor to custom collector docs * revert changes in docs * fix component order in docs (cherry picked from commit 6c2491c)
|
We just had a zoom call with @andrzej-stencel and @AlexanderWert and concluded that removing this processor would be a breaking change, which we'd like to avoid. On the other hand, the code of the elastic trace processor is already removed from the collector components repo, so the last version depends on older upstream components, which makes bumping versions harder - so this would have not worked probably anyways as it was in this repo. Plan is that I'll try to create a small processor with the same name |
* sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v0\.135.0/\1 v0.137.0/' go.mod * sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v1\.41\.0/\1 v1.43.0/' go.mod * sed -i 's/\(github\.com\/open-telemetry\/opentelemetry\-collector\-contrib\/.*\) v0\.135\.0/\1 v0.137.0/' go.mod * go mod tidy * update Elastic components * remove Elastic Trace processor In anticipation of #10378 * go get go.opentelemetry.io/[email protected] * go mod tidy * add changelog entry
* sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v0\.135.0/\1 v0.137.0/' go.mod * sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v1\.41\.0/\1 v1.43.0/' go.mod * sed -i 's/\(github\.com\/open-telemetry\/opentelemetry\-collector\-contrib\/.*\) v0\.135\.0/\1 v0.137.0/' go.mod * go mod tidy * update Elastic components * remove Elastic Trace processor In anticipation of #10378 * go get go.opentelemetry.io/[email protected] * go mod tidy * add changelog entry (cherry picked from commit 7ea323e) # Conflicts: # go.mod # go.sum # internal/pkg/otel/README.md
…10406) * feat!: remove Elastic Trace processor from EDOT Collector It is replaced with the Elastic APM processor. * fix: add Elastic APM processor to custom collector docs * revert changes in docs * fix component order in docs (cherry picked from commit 6c2491c) Co-authored-by: Andrzej Stencel <[email protected]>
* sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v0\.135.0/\1 v0.137.0/' go.mod * sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v1\.41\.0/\1 v1.43.0/' go.mod * sed -i 's/\(github\.com\/open-telemetry\/opentelemetry\-collector\-contrib\/.*\) v0\.135\.0/\1 v0.137.0/' go.mod * go mod tidy * update Elastic components * remove Elastic Trace processor In anticipation of #10378 * go get go.opentelemetry.io/[email protected] * go mod tidy * add changelog entry (cherry picked from commit 7ea323e) # Conflicts: # go.mod # go.sum # internal/pkg/otel/README.md Co-authored-by: Andrzej Stencel <[email protected]>
* sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v0\.135.0/\1 v0.137.0/' go.mod * sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v1\.41\.0/\1 v1.43.0/' go.mod * sed -i 's/\(github\.com\/open-telemetry\/opentelemetry\-collector\-contrib\/.*\) v0\.135\.0/\1 v0.137.0/' go.mod * go mod tidy * update Elastic components * remove Elastic Trace processor In anticipation of #10378 * go get go.opentelemetry.io/[email protected] * go mod tidy * add changelog entry (cherry picked from commit 7ea323e) # Conflicts: # NOTICE-fips.txt # NOTICE.txt # go.mod # go.sum # internal/pkg/otel/README.md
* sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v0\.135.0/\1 v0.137.0/' go.mod * sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v1\.41\.0/\1 v1.43.0/' go.mod * sed -i 's/\(github\.com\/open-telemetry\/opentelemetry\-collector\-contrib\/.*\) v0\.135\.0/\1 v0.137.0/' go.mod * go mod tidy * update Elastic components * remove Elastic Trace processor In anticipation of #10378 * go get go.opentelemetry.io/[email protected] * go mod tidy * add changelog entry (cherry picked from commit 7ea323e) # Conflicts: # NOTICE-fips.txt # NOTICE.txt # go.mod # go.sum # internal/pkg/otel/README.md
….137.0 (#10543) * feat: update OTel Collector components to v0.137.0 (#10391) * sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v0\.135.0/\1 v0.137.0/' go.mod * sed -i 's/\(go\.opentelemetry\.io\/collector.*\) v1\.41\.0/\1 v1.43.0/' go.mod * sed -i 's/\(github\.com\/open-telemetry\/opentelemetry\-collector\-contrib\/.*\) v0\.135\.0/\1 v0.137.0/' go.mod * go mod tidy * update Elastic components * remove Elastic Trace processor In anticipation of #10378 * go get go.opentelemetry.io/[email protected] * go mod tidy * add changelog entry (cherry picked from commit 7ea323e) # Conflicts: # NOTICE-fips.txt # NOTICE.txt # go.mod # go.sum # internal/pkg/otel/README.md * fix: resolve conflicts * fix: StartMockES * [otel] Add back elastictrace processor * fix: resolve gaps from rebasing * fix: unit-tests * fix: update beats to latest version on 8.19 * fix: otelconfig_test.go --------- Co-authored-by: Andrzej Stencel <[email protected]> Co-authored-by: Panos Koutsovasilis <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
What does this PR do?
Removes the Elastic Trace processor from EDOT Collector, replacing all usages with its direct drop-in replacement, the Elastic APM processor.
Why is it important?
The Elastic Trace processor was deprecated and its code was removed in elastic/opentelemetry-collector-components#784.
Checklist
./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testDisruptive User Impact
This is a breaking change for users if they use the processor in their EDOT Collector configurations.
The fix is simple: replace
elastictracewithelasticapmin their configurations.How to test this PR locally